Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 support #40

Closed
waza-ari opened this issue Jan 12, 2025 · 2 comments · Fixed by #41
Closed

Python 3.13 support #40

waza-ari opened this issue Jan 12, 2025 · 2 comments · Fixed by #41

Comments

@waza-ari
Copy link
Contributor

waza-ari commented Jan 12, 2025

Your package is being used in other libraries (for example Taskiq), which do support Python 3.13.

When installing those libraries on Python 3.13, they resolve to pycron version 3.0.0, because newer pycron versions specify Python version constraints, while older ones do not. This leads to situations like this, where the version constraints theoretically allow an update, but the Python version constraints do not:

$ poetry update
Updating dependencies
Resolving dependencies... (2.2s)

No dependencies to install or update

$ poetry show -o                                                  
pycron    3.0.0  3.1.1  Simple cron-like parser, which determines if current datetime matches conditions.

$ poetry show --why --tree pycron   
taskiq 0.11.10 Distributed task queue with full async support
└── pycron >=3.0.0,<4.0.0

I'm preparing a Merge Request to add Python 3.13 support to pycron. There is a dependency which doesn't have Python 3.13 support either, therefore I'm adding this issue here for tracking, which can be picked up once TheKevJames/coveralls-python#549 is resolved.

@kipe
Copy link
Owner

kipe commented Jan 12, 2025

I think we could just drop coveralls-python, as it doesn't seem to be that well maintained. We could just require 100 % test coverage in the tests instead, then coveralls is more or less useless anyways.

@waza-ari
Copy link
Contributor Author

Hey, sounds good to me. Was looking through their repo and found it to be somewhat abandoned. Removing coveralls would probably also mean dropping the badge in the Readme, are you fine with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants