refactor(redux, types): use typed dispatch and selector #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@curtisy1 is attempting to deploy a commit to the Justin Maximillian Kimlim's projects Team on Vercel. A member of the Team first needs to authorize it. |
This is recommended as per the redux toolkit quickstart https://redux-toolkit.js.org/tutorials/typescript#define-typed-hooks
curtisy1
force-pushed
the
simplify-redux-types
branch
from
85734e1
to
0acc7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is recommended as per the redux toolkit quickstart https://redux-toolkit.js.org/tutorials/typescript#define-typed-hooks
Motivation
Specifying the whole Typescript types for each selector is overkill and can easily be simplified
Changes
Introduce two new hooks,
useAppDispatchanduseAppSelectorwhich are type-safe global wrappers foruseDispatchanduseSelector