Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding yflip option #36

Closed
kimikage opened this issue Jun 5, 2020 · 2 comments · Fixed by #53
Closed

Adding yflip option #36

kimikage opened this issue Jun 5, 2020 · 2 comments · Fixed by #53
Milestone
0.2

Comments

@kimikage
Copy link
Owner

kimikage commented Jun 5, 2020

cf. timholy/ProfileView.jl#22

The PR #34 introduces set_default(), so I'm not going to change the default orientation.
@kimikage
Copy link
Owner Author

kimikage commented Jun 6, 2020

The original "flamegraph.pl" uses the inverted option for generating icicle graphs. However, I do not like the name because it is ambiguous.
flip_y is clearer, but the y doesn't make sense on sunburst charts.

@kimikage kimikage changed the title Adding flip_y option Adding yflip option Jun 17, 2020
@kimikage
Copy link
Owner Author

yflip seems better than flip_y, since the yflip option is used in Plots.jl and the name does not include non-alphabetic symbols.

@kimikage kimikage added this to the 0.2 milestone Jun 17, 2020
@kimikage kimikage mentioned this issue Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Add yflip option kimikage/ProfileSVG.jl
1 participant
@kimikage