Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --no-squash on single-commit GitLab MR #93

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

peat-psuwit
Copy link
Contributor

Due to off-by-one error in GitLabMapper, --no-squash was not effective on an MR containing single commit. Fix by using the same condition as GitHubMapper.

Thank you for submitting this pull request

Checklist

  • Tests added if applicable.
  • Documentation updated if applicable.

Note: dist/cli/index.js and dist/gha/index.js are automatically generated by git hooks and gh workflows.

First time here?

This project follows git conventional commits pattern, therefore the commits should have the following format:

<type>(<optional scope>): <subject>
empty separator line
<optional body>
empty separator line
<optional footer>

Where the type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

NOTE: if you are still in a work in progress branch and you want to push your changes remotely, consider adding --no-verify for both commit and push, e.g., git push origin <feat-branch> --no-verify - this could become useful to push changes where there are still tests failures. Once the pull request is ready, please amend the commit and force-push it to keep following the adopted git commit standard.

How to prepare for a new release?

There is no need to manually update package.json version and CHANGELOG.md information. This process has been automated in Prepare Release Github workflow.

Therefore whenever enough changes are merged into the main branch, one of the maintainers will trigger this workflow that will automatically update version and changelog based on the commits on the git tree.

More details can be found in package release section of the README.

Due to off-by-one error in GitLabMapper, --no-squash was not effective
on an MR containing single commit. Fix by using the same condition as
GitHubMapper.
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 90.26% 417/462
🟢 Branches 82.83% 164/198
🟢 Functions 88.98% 105/118
🟢 Lines 90.22% 406/450

Test suite run success

167 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 605dcd9

@peat-psuwit peat-psuwit marked this pull request as draft February 19, 2024 20:59
@peat-psuwit peat-psuwit marked this pull request as ready for review February 20, 2024 08:54
@lampajr
Copy link
Member

lampajr commented Feb 20, 2024

Hi @peat-psuwit , thanks a lot for opening this pr 🚀

After quick check looks really good (thanks for adding the tests!!!), I will give it a deeper check asap :)

@lampajr lampajr self-requested a review February 20, 2024 13:23
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks a lot for this contribution @peat-psuwit 🚀

@lampajr lampajr merged commit 300fa91 into kiegroup:main Feb 20, 2024
4 checks passed
@peat-psuwit peat-psuwit deleted the fix-no-squash-gitlab branch October 3, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants