Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance by concurrently setting labels, reviewers and assignees #49

Closed
shubhbapna opened this issue Jul 7, 2023 · 0 comments · Fixed by #59
Closed

improve performance by concurrently setting labels, reviewers and assignees #49

shubhbapna opened this issue Jul 7, 2023 · 0 comments · Fixed by #59
Labels
performance Performance related task

Comments

@shubhbapna
Copy link
Contributor

Currently we are setting labels, reviewers and assignees one by one. See: https://github.com/kiegroup/git-backporting/blob/main/src/service/git/github/github-client.ts#L69

However, we can take advantage of promises here and trigger all the API calls concurrently and await them together. We can use Promise.all or Promise.allSettled
@shubhbapna shubhbapna mentioned this issue Jul 7, 2023
Merged
2 tasks
@lampajr lampajr added the enhancement New feature or request label Jul 9, 2023
@shubhbapna shubhbapna mentioned this issue Jul 11, 2023
Merged
@lampajr lampajr added performance Performance related task and removed enhancement New feature or request labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: use concurrent promises instead of awaiting them one by one shubhbapna/git-backporting
2 participants
@lampajr @shubhbapna