MLB:1856: changed copy on backingfragment whe plot selected #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2181 +/- ##
=========================================
Coverage 68.65% 68.66%
- Complexity 2167 2168 +1
=========================================
Files 348 348
Lines 23179 23186 +7
Branches 3390 3391 +1
=========================================
+ Hits 15914 15920 +6
Misses 5453 5453
- Partials 1812 1813 +1 ☔ View full report in Codecov by Sentry. |
Arkariang
reviewed
Dec 2, 2024
| @@ -534,13 +562,22 @@ interface BackingFragmentViewModel { | |||
| Backing.STATUS_COLLECTED -> R.string.We_collected_your_pledge_for_this_project | |||
| Backing.STATUS_DROPPED -> R.string.Your_pledge_was_dropped_because_of_payment_errors | |||
| Backing.STATUS_ERRORED -> R.string.We_cant_process_your_pledge_Please_update_your_payment_method | |||
| Backing.STATUS_PLEDGED -> R.string.If_your_project_reaches_its_funding_goal_the_backer_will_be_charged_total_on_project_deadline | |||
| Backing.STATUS_PLEDGED -> { | |||
There was a problem hiding this comment.
@jlplks add tests for the new string, take a look here to see an example -> @Test fun testFixPaymentMethodButtonIsGone_whenBackingIsErrored() at BackingFragmentViewModelTest.kt
Arkariang
previously approved these changes
Dec 2, 2024
Arkariang
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
changed copy on backingfragment whe plot selected
🤔 Why
Because copy should be different when plot is selected
🛠 How
adding validation with feature flag and project.isPledOverTimeAllowed