Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v0.4.0 #11

Merged
merged 14 commits into from
Sep 5, 2024
Merged

upgrade to v0.4.0 #11

merged 14 commits into from
Sep 5, 2024

Conversation

khusmann
Copy link
Owner

@khusmann khusmann commented Sep 5, 2024

New features:

The interlacer rule is "operations are applied to the value channel"
and missing values are automatically masked out. the original
behavior did not follow this in order to allow for comparsion
of missing reasons. Instead, for missing reason comparsions
we will need to define new equality operators that compare
both values and missing reason channels.

See discussion here for more info: r-lib/vctrs#1928
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.84%. Comparing base (5f92d87) to head (92255f6).

Files with missing lines Patch % Lines
R/interlaced.R 78.94% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   65.51%   65.84%   +0.32%     
==========================================
  Files          12       12              
  Lines        1041     1051      +10     
==========================================
+ Hits          682      692      +10     
  Misses        359      359              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khusmann khusmann merged commit edfd254 into main Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants