Skip to content

Commit

Permalink
comparisons should be made on the value channel only
Browse files Browse the repository at this point in the history
The interlacer rule is "operations are applied to the value channel"
and missing values are automatically masked out. the original
behavior did not follow this in order to allow for comparsion
of missing reasons. Instead, for missing reason comparsions
we will need to define new equality operators that compare
both values and missing reason channels.

See discussion here for more info: r-lib/vctrs#1928
  • Loading branch information
khusmann committed Sep 5, 2024
1 parent 5f92d87 commit 8f27374
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion R/interlaced.R
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ vec_restore.interlacer_interlaced <- function(x, to, ...) {

#' @export
vec_proxy_equal.interlacer_interlaced <- function(x, ...) {
if_else(is.empty(x), list(NULL), vec_chop(x))
value_channel(x)
}

#' @export
Expand Down

0 comments on commit 8f27374

Please sign in to comment.