Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Baseline vertical alignment #88

Open
ecton opened this issue Dec 15, 2023 · 0 comments · May be fixed by #227
Open

Add Baseline vertical alignment #88

ecton opened this issue Dec 15, 2023 · 0 comments · May be fixed by #227

Comments

@ecton
Copy link
Member

ecton commented Dec 15, 2023

The new Wrap widget looks kinda wonky when there are varying baselines. The layout() function should be refactored to return a new type that contains both a size and a baseline: Option<UPx>. This baseline should be propagated up by other widgets when laying out children that report back a baseline.
@ecton ecton mentioned this issue Jan 7, 2024
Closed
@ecton ecton moved this to Todo in Cushy Roadmap Jan 12, 2024
ecton added a commit that referenced this issue Nov 30, 2024
@ecton
Added WidgetLayout + Baseline
feb3a35 
Refs #88

This set of changes starts working towards supporting baseline
alignment. The Grid widget currently does not honor vertical align in
any way, but it in theory propagates the first row's baseline
information -- which will need to be adjusted if Baseline vertical
alignment is used.

Next step is to actually add Baseline and try to make it work. The set
of changes thus far was just so massive and I finally resolved all the
errors from this refactoring.
@ecton ecton linked a pull request Nov 30, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Cushy Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Baseline Vertical Alignment khonsulabs/cushy
1 participant
@ecton