FancyTodos Mohammad Fitrah Ramadhan Lamusu #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nama file controller diubah ya jadi TodoController |
|
untuk validasi tanggal tidak bisa menggunakan isAfter karena argsnya jalan ketika server dijalankan, misal server nyala di 17 agustus , di 19 agustus kita masih bisa bikin todo untuk 18 agustus (karena new date nya dibuat saat 17 agustus) |
|
validasi not null ditambah ya di title, dan description, dan due date |
|
tambah model user register login |
|
dhimashary
reviewed
Oct 28, 2020
server/controller/todo-controller.js
Outdated
| try { | ||
| const newTodo = req.body | ||
| newTodo.UserId = UserId | ||
| const create = await Todo.create(newTodo) |
There was a problem hiding this comment.
ini jangan langsung req body, bisa aja di req body gw masukin field yang ga ada di model , jadi musti dipilih dulu misal Todo.create({ title: req.body.title, dst })
dhimashary
reviewed
Oct 28, 2020
server/controller/user-controller.js
Outdated
| class UserController { | ||
| static async postUserRegister(req, res) { | ||
| try { | ||
| const newUser = req.body |
There was a problem hiding this comment.
jangan langsung req body
…rm still error, add form still error and no 3rd party API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on progress