Muhammad Akbar Habiby Khalid #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need improvement:
|
done kak sudah di perbaiki |
dhimashary
reviewed
Oct 28, 2020
| const status = req.body.status | ||
| const patched = await Todo.update({ status }, { where: { id }, returning: true }) | ||
|
|
||
| res.status(200).json(patched[1][0]) |
There was a problem hiding this comment.
lebih baik di cek dulu patched ke 0 nya 0 atau bukan, kalo bukan berarti ada yg keupdate, kalo 0 berarti ga ada yg keupdate
dhimashary
reviewed
Oct 28, 2020
| static async deleteTodoById(req, res, next) { | ||
| try { | ||
| const id = +req.params.id | ||
| await Todo.destroy({ where: { id }}) |
There was a problem hiding this comment.
ini juga lebih baik di simpan ke variabel dan dilihat hasil deletenya 0 atau bukan, kalo 0 berarti ga ada yg kedelete
|
penamaan file baiknya konsisten ya, misal jika kebab case, kebab case semua ga ada yg camel case. terus superman sama batman nya tolong di rename ya :D |
Fixed ISO Date, converted to normal date
Added Heroku Config
|
good job ! keep up the good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.