Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility: Advanced Magic - Spell Points System 5e #247

Closed
Kharmans opened this issue Jan 12, 2024 · 9 comments
Closed

Compatibility: Advanced Magic - Spell Points System 5e #247

Kharmans opened this issue Jan 12, 2024 · 9 comments
Assignees
Labels
compatibility Foundry module compatibility is needed

Comments

@Kharmans
Copy link
Contributor

The module Advanced Magic - Spell Points System 5e adapts the Spell Points, but it doesn't work with this module.

@kgar
Copy link
Owner

kgar commented Jan 13, 2024

I pulled down the module to test. I see some functionality works, such as setting a resource to "Spell Points" and having spell points get deducted when casting spells. Also, spell point recalculation on level up or class item drop seems to work.

Which specific functionality is not working?

@kgar
Copy link
Owner

kgar commented Jan 13, 2024

This looks to be missing on my sheets:
image

I can work with the module author on that.
Is there anything else in particular that doesn't work?

@Kharmans
Copy link
Contributor Author

It's exactly the option "Enable Mixed Mode" that doesn't show. And if you don't use that option, the Spell Point are not automatically deducted when casting spells.

What I have to do is enable the "Enable Mixed Mode" option, change the sheet template to Foundry default, enable the Mixed Mode option and change to Tidy5eSheet template. That's the only way I can make the module works.

@kgar
Copy link
Owner

kgar commented Jan 26, 2024

Gotcha. I am currently doing compatibility work for Magic Items 2, which is taking a lot of time, but when I get free to work on this, I will try to get it resolved. Much will depend on the module author, but as a backup plan, I can also provide a World Script to shim the functionality until the module author is able to update the module.

@kgar
Copy link
Owner

kgar commented Jan 26, 2024

I've gotten the conversation with the module author started here: misthero/dnd5e-spellpoints#63

@kgar
Copy link
Owner

kgar commented Jan 27, 2024

The module author is planning to establish compatibility for this module and 5e - Custom Abilities & Skills 🎉

@kgar kgar self-assigned this Jan 27, 2024
@Kharmans
Copy link
Contributor Author

Thank you man! I'll wait.

@kgar
Copy link
Owner

kgar commented May 18, 2024

@Kharmans from the module author, we are now compatible:
image
misthero/dnd5e-spellpoints#63 (comment)

Let me know if you need anything else. I'll give this issue a week or so, or until I hear back from you, whichever is sooner, and I'll close it.

@kgar kgar added the pending-closure This issue may be resolved and is awaiting confirmation / enough time without a response to close. label May 18, 2024
@Kharmans
Copy link
Contributor Author

@kgar, I just test it. It's working! Thanks for this!

@kgar kgar removed the pending-closure This issue may be resolved and is awaiting confirmation / enough time without a response to close. label May 19, 2024
@kgar kgar closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Foundry module compatibility is needed
Development

No branches or pull requests

2 participants