From c73564ebb6c2dc92b73047e495886b30d3932a77 Mon Sep 17 00:00:00 2001 From: Ben Abrams Date: Fri, 18 Dec 2020 09:06:42 -0800 Subject: [PATCH] remove `ForceNew` on `template*` as they are concerns only at creation time (#609) There are a number of resources that have been marked as `ForceNew: true` out of a desire in "correctness" by those that do not actually understand how these resources are used in the real world and damage that can be done. No one wants to blow up a repository to change something like this, if they need to there is a mechanism built into terraform called [taint](https://www.terraform.io/docs/commands/taint.html). While there are some things that make sense for using `ForceNew` a repository for source control on properties that the API will ignore outside of creation is not one of them. Signed-off-by: Ben Abrams --- github/resource_github_repository.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/github/resource_github_repository.go b/github/resource_github_repository.go index 8f06df695d..275d945eb0 100644 --- a/github/resource_github_repository.go +++ b/github/resource_github_repository.go @@ -106,13 +106,11 @@ func resourceGithubRepository() *schema.Resource { }, "license_template": { Type: schema.TypeString, - Optional: true, - ForceNew: true, + Optional: true }, "gitignore_template": { Type: schema.TypeString, Optional: true, - ForceNew: true, }, "archived": { Type: schema.TypeBool, @@ -167,7 +165,6 @@ func resourceGithubRepository() *schema.Resource { "template": { Type: schema.TypeList, Optional: true, - ForceNew: true, MaxItems: 1, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{