From 29a1a12e4462c61c8573fb448a4226d1edf8ee30 Mon Sep 17 00:00:00 2001 From: Cho Chi Him Date: Mon, 30 Nov 2020 21:04:52 +0800 Subject: [PATCH 1/2] Update Controller.js Fix bug that valid values like 0 or empty string are serialized into `null` --- packages/fields/src/Controller.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/fields/src/Controller.js b/packages/fields/src/Controller.js index a35d319f2d7..1a72ecb2f8e 100644 --- a/packages/fields/src/Controller.js +++ b/packages/fields/src/Controller.js @@ -51,7 +51,13 @@ export default class FieldController { * `Implementation#gqlCreateInputFields()`/`Implementation#gqlUpdateInputFields()` * NOTE: This function is run synchronously */ - serialize = data => data[this.path] || null; + serialize = data => { + if (data[this.path] === undefined) { + return null; + } + + return data[this.path]; + } /** * Tell the AdminUI there has been an error with this field From e78f2f3b2ca5247bca1a200d66c3cd4abdb6de6e Mon Sep 17 00:00:00 2001 From: Maxi Cho Date: Mon, 30 Nov 2020 21:24:54 +0800 Subject: [PATCH 2/2] add changeset --- .changeset/pretty-kids-rhyme.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/pretty-kids-rhyme.md diff --git a/.changeset/pretty-kids-rhyme.md b/.changeset/pretty-kids-rhyme.md new file mode 100644 index 00000000000..47f75dac438 --- /dev/null +++ b/.changeset/pretty-kids-rhyme.md @@ -0,0 +1,5 @@ +--- +'@keystonejs/fields': patch +--- + +Fix bug that valid values like 0 or empty string are serialized into `null`