Add API tests for CloudinaryImage field type #3467

singhArmani · 2020-08-25T05:42:17Z

Added filter, isRequired tests for CloudinaryImage field type.
Used github secrets in git workflow ('jest')
Cleanup cloudinary resources after tests are completed to avoid exceeding the upload limit.

changeset-bot · 2020-08-25T05:42:19Z

🦋 Changeset is good to go

Latest commit: 6201507

We got this.

This PR includes changesets to release 2 packages

Name	Type
@keystonejs/api-tests	Patch
@keystonejs/fields-cloudinary-image	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

timleslie

A few comments and questions below.

timleslie · 2020-08-25T05:49:07Z

.changeset/tiny-rockets-lick.md

+'@keystonejs/fields-cloudinary-image': patch
+---
+
+Add `filter`, `isRequired` and CRUD tests for `CloudinaryImage` field type.


Suggested change

Add `filter`, `isRequired` and CRUD tests for `CloudinaryImage` field type.

Added `filter`, `isRequired` and CRUD tests for `CloudinaryImage` field type.

timleslie · 2020-08-25T05:50:27Z

packages/keystone/package.json

@@ -31,7 +31,7 @@
    "express-pino-logger": "^4.0.0",
    "falsey": "^1.0.0",
    "fs-extra": "^7.0.0",
-    "globby": "^11.0.0",
+    "globby": "^11.0.1",


The package version bumps here should result in a changeset for all the affected packages. In general it's probably best to leave and version bumps out of a feature PR like this unless they're actually required.

timleslie · 2020-08-25T05:51:18Z

packages/fields-cloudinary-image/src/test-fixtures.js

+
+// This function will run after all the tests are completed.
+// We use it to cleanup the resources (e.g Cloudinary images) which are no longer required.
+export const afterAll = () => cloudinary.v2.api.delete_resources_by_prefix('cloudinary-test');


Let's move this code up to the top section of the file. We want to keep all the module config in a single location.

timleslie · 2020-08-25T05:52:02Z

packages/fields-cloudinary-image/src/test-fixtures.js

+};
+
+export const initItems = () => {
+  let items = testFiles.map((p, i) => ({ name: `file${i}`, image: prepareFile(p) }));


Suggested change

let items = testFiles.map((p, i) => ({ name: `file${i}`, image: prepareFile(p) }));

const items = testFiles.map((p, i) => ({ name: `file${i}`, image: prepareFile(p) }));

packages/fields-cloudinary-image/src/test-fixtures.js

.github/workflows/tests.yml

Co-authored-by: Renovate Bot <[email protected]>

* Add filter and CRUD test for Unsplash field * Add delete operation API test Unsplash field type

* Removed unsupported filter options for field types (#3501) * Add delete operation API test LocationGoogle

Co-authored-by: Renovate Bot <[email protected]>

* Add filter and CRUD tests for AutoIncrement field * Remove unsupported adapter field type tests

* Add filter & CRUD tests for MongoId field * Fix the _in: null filter operation in mongoid

Co-authored-by: Renovate Bot <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Rename demo-projects folder to examples * Update test-projects/README.md Co-authored-by: Tim Leslie <[email protected]> * Fix some strange git ignoreness Co-authored-by: Tim Leslie <[email protected]>

singhArmani · 2020-09-01T07:16:24Z

Fixing this mess in another branch.

singhArmani added the review me label Aug 25, 2020

singhArmani force-pushed the add-filter-tests-cloudinary branch from 0a54045 to 0ef5284 Compare August 25, 2020 05:48

timleslie suggested changes Aug 25, 2020

View reviewed changes

emmatown reviewed Aug 25, 2020

View reviewed changes

.github/workflows/tests.yml Show resolved Hide resolved

singhArmani force-pushed the add-filter-tests-cloudinary branch from 0ef5284 to d43ae1c Compare August 27, 2020 06:26

renovate bot and others added 24 commits August 27, 2020 16:57

Update dependency eslint-plugin-cypress to ^2.11.1 (#3485)

c890a3d

Co-authored-by: Renovate Bot <[email protected]>

Update dependency @preconstruct/cli to v1.1.26 (#3499)

cfcdd9b

Co-authored-by: Renovate Bot <[email protected]>

Update dependency eslint-plugin-import to ^2.22.0 (#3488)

f635d20

Co-authored-by: Renovate Bot <[email protected]>

Update dependency eslint-plugin-react to ^7.20.6 (#3489)

4e8cb8a

Co-authored-by: Renovate Bot <[email protected]>

Update babel monorepo (#3439)

0fc878f

Update dependency cfonts to ^2.8.6 (#3464)

9e978e5

Update dependency cookie to ^0.4.1 (#3472)

07e246d

Add tests for OEmbed field (#3462)

43646b6

Add filter and CRUD test for Unsplash field (#3473)

febe970

* Add filter and CRUD test for Unsplash field * Add delete operation API test Unsplash field type

Add filter, CRUD tests for LocationGoogle field (#3476)

e261c97

* Removed unsupported filter options for field types (#3501) * Add delete operation API test LocationGoogle

Update dependency jest-junit to ^11.1.0 (#3512)

57d838d

Co-authored-by: Renovate Bot <[email protected]>

Update dependency @mapbox/rehype-prism to ^0.5.0 (#3446)

1a5e785

Update dependency babel-preset-react-app to ^9.1.2 (#3460)

64d7450

Update dependency chrono-node to ^1.4.8 (#3466)

fcf632d

Update dependency cors to ^2.8.5 (#3478)

7f04d9d

Add filter and CRUD tests for AutoIncrement field (#3415)

bbeb0f7

* Add filter and CRUD tests for AutoIncrement field * Remove unsupported adapter field type tests

Add filter & CRUD tests for MongoId field (#3419)

64eba48

* Add filter & CRUD tests for MongoId field * Fix the _in: null filter operation in mongoid

Update dependency css-loader to ^3.6.0 (#3479)

dc689f9

Update dependency @changesets/cli to ^2.10.2 (#3518)

878dbb8

Co-authored-by: Renovate Bot <[email protected]>

Version Packages (#3434)

06eb77a

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Update dependency cypress to ^4.12.1 (#3480)

98c8dbf

Update dependency cypress-file-upload to ^3.5.3 (#3482)

5bed4db

Update dependency cypress-multi-reporters to ^1.4.0 (#3483)

31959b7

Update dependency graphql to ^14.7.0 (#3510)

cd15192

renovate bot and others added 23 commits August 31, 2020 10:58

Update dependency node-fetch to ^2.6.0 (#3524)

e62b330

Update dependency mocha to ^7.2.0 (#3515)

39145cf

Update dependency knex to ^0.21.5 (#3513)

e9bc436

Update Apollo GraphQL packages (#3507)

28b88ab

Update dependency @types/react to ^16.9.48 (#3496)

729e897

Update dependency pg to ^8.3.3 (#3526)

003b856

Rename demo-projects folder to examples (#3534)

639a11f

* Rename demo-projects folder to examples * Update test-projects/README.md Co-authored-by: Tim Leslie <[email protected]> * Fix some strange git ignoreness Co-authored-by: Tim Leslie <[email protected]>

Update dependency superagent to ^6.1.0 (#3533)

38c229d

Update dependency webpack to v4.44.1 (#3536)

5fb75ba

Update dependency @reach/skip-nav to ^0.10.5 (#3471)

94aaa1b

Update dependency get-workspaces to ^0.5.2 (#3503)

b2bd202

Update dependency cloudinary to ^1.23.0 (#3490)

7fb51fb

Update dependency endent to ^1.4.1 (#3484)

d71f987

Update dependency gatsby-remark-check-links to ^2.1.0 (#3502)

8c3f8a9

Update jest monorepo (#3543)

935147b

Update dependency html-webpack-plugin to ^4.4.1 (#3523)

40b751a

Update typescript-eslint monorepo to ^3.10.1 (#3547)

285dd28

Add blog section to website (#3306)

234627a

Remove unused dependencies (#3509)

2d00997

Update dependency date-fns to ^2.16.1 (#3508)

a42ee3a

Update dependency aws-sdk to ^2.743.0 (#3498)

743646a

Add API tests for CloudinaryImage field type

b89d6cf

Use Upload instance for Cloudinary Field test

20a1bca

singhArmani requested a review from timleslie September 1, 2020 06:59

singhArmani closed this Sep 1, 2020

timleslie deleted the add-filter-tests-cloudinary branch December 21, 2020 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add API tests for CloudinaryImage field type #3467

Add API tests for CloudinaryImage field type #3467

singhArmani commented Aug 25, 2020

changeset-bot bot commented Aug 25, 2020 •

edited

Loading

timleslie left a comment

timleslie Aug 25, 2020

timleslie Aug 25, 2020

timleslie Aug 25, 2020

timleslie Aug 25, 2020

singhArmani commented Sep 1, 2020

	Add `filter`, `isRequired` and CRUD tests for `CloudinaryImage` field type.
	Added `filter`, `isRequired` and CRUD tests for `CloudinaryImage` field type.

	let items = testFiles.map((p, i) => ({ name: `file${i}`, image: prepareFile(p) }));
	const items = testFiles.map((p, i) => ({ name: `file${i}`, image: prepareFile(p) }));

Add API tests for CloudinaryImage field type #3467

Add API tests for CloudinaryImage field type #3467

Conversation

singhArmani commented Aug 25, 2020

changeset-bot bot commented Aug 25, 2020 • edited Loading

🦋 Changeset is good to go

timleslie left a comment

Choose a reason for hiding this comment

timleslie Aug 25, 2020

Choose a reason for hiding this comment

timleslie Aug 25, 2020

Choose a reason for hiding this comment

timleslie Aug 25, 2020

Choose a reason for hiding this comment

timleslie Aug 25, 2020

Choose a reason for hiding this comment

singhArmani commented Sep 1, 2020

changeset-bot bot commented Aug 25, 2020 •

edited

Loading