Add filter tests to URL field type #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: bfa3c86 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue. |
MadeByMike
reviewed
Aug 11, 2020
MadeByMike
reviewed
Aug 11, 2020
timleslie
suggested changes
Aug 11, 2020
singhArmani
force-pushed
the
url-field-filter-tests
branch
2 times, most recently
from
5df1bd8 to
67c0e0f
Compare
This is about black-box testing the API to ensure that it behaves in the way we expect, independent of what we know about the implementation details. This is important for verifying the correctness of the prisma adapter in #3298 . |
singhArmani
force-pushed
the
url-field-filter-tests
branch
from
67c0e0f to
4c60a0f
Compare
singhArmani
force-pushed
the
url-field-filter-tests
branch
from
4c60a0f to
bfa3c86
Compare
This was referenced Aug 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.