Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm instead of Yarn #3365

Closed
wants to merge 21 commits into from
Closed

Use pnpm instead of Yarn #3365

wants to merge 21 commits into from

Conversation

emmatown
Copy link
Member

Why pnpm?

  • It's faster than Yarn in most cases(v1, using Yarn v2 would be unpalatable in my opinion because of the compatibility problems of PnP)
  • Because of the node_modules structure it creates, it's possible to have conflicting versions of some package and the conflicting versions can be shared across different usages rather than the package being duplicated(This is important if we want to have different versions of packages so that we don't run into problems around duplicated copies of the same package at a given version)
  • It doesn't let packages access all the dependencies of every other package because of the node_modules structure
  • I've been using it on quite a few projects recently and have found it to be more reliable/I've basically never had to rm -rf node_modules

(This isn't ready rn, I'm just opening this so CI runs)

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2020

💥 No Changeset

Latest commit: 74be8dc

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emmatown
Copy link
Member Author

It seems like Cypress or a dependency of it has an incorrect implementation of Node's module resolution algorithm and it's probably not worth digging deep into it right now so I'm gonna close this. I might have another look at this in the future though.

@emmatown emmatown closed this Aug 14, 2020
@timleslie timleslie deleted the use-pnpm branch November 9, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant