Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use authedGraphqlRequest rather than networkedGraphqlRequest #3310

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

timleslie
Copy link
Contributor

We should only be using networkedGraphqlRequest if we're actually interested in the way the test interacts with the network requests.

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2020

🦋 Changeset is good to go

Latest commit: 593c2ff

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/api-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timleslie timleslie force-pushed the non-networked-requests branch from d087f3c to 5e3ac8d Compare July 30, 2020 04:17
Copy link
Contributor

@singhArmani singhArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@timleslie timleslie force-pushed the non-networked-requests branch from 5e3ac8d to 593c2ff Compare July 30, 2020 04:51
@timleslie timleslie merged commit cefbca4 into master Jul 30, 2020
@timleslie timleslie deleted the non-networked-requests branch July 30, 2020 05:04
This was referenced Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants