-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Prisma adapter #3298
Add a Prisma adapter #3298
Conversation
🦋 Changeset detectedLatest commit: 66c00bc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fa71a11
to
37c5933
Compare
6a0d655
to
ad28984
Compare
d3f9e66
to
6196387
Compare
580b53b
to
2110bb5
Compare
// JM: I wonder if performing a regex match here leaks any timing info that | ||
// could be used to extract information about the hash.. :/ | ||
return { | ||
// FIXME: Prisma needs to support regex matching... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a prisma issue about this? I tried searching on the prisma repo but couldn't find anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I know of, it's something I need to bring up with them, I just need to take the time to formulate the question properly so I can explain exactly what the feature would look like.
f86764d
to
451078a
Compare
30163e5
to
f699229
Compare
f699229
to
59390ae
Compare
59390ae
to
66c00bc
Compare
Prisma 2 has recently been released. It provides a powerful javascript library for interfacing with databases. The Prisma team have recently received significant funding to continue development of their library.
This PR introduces support for using Prisma as a database adapter within Keystone.
We are still reviewing Prisma for feature completeness and correctness to ensure that all of Keystone's features will work as expected.
We are also investigating the Prisma migration framework in order to provide a better DX for developers who need to perform migrations on their database as their Keystone system evolves.
Note: This PR is still WIP, particularly in regard to how, where and when we are generating the Prisma client.
See also: prisma/prisma#3265
Feature Completeness
Relationships
prisma/prisma#3141prisma/prisma#3078prisma/prisma#3153Fields
CalendarDay
DateTime
Checkbox
Boolean
DateTime
DateTime
+String
DateTimeUtc
DateTime
Decimal
N/A
File
Json
Float
Float
Integer
Int
Password
String
Relationship
@relation
Select
Enum
|Int
|String
Slug
String
Text
String
prisma/prisma-client-js#690Url
String
prisma/prisma-client-js#690Uuid
String
String
here for now, but we should really work out how to get an actualuuid
columnVirtual
Color
String
prisma/prisma-client-js#690Content
@relation
AuthedRelationship
@relation
AutoIncrement
Int
CloudinaryImage
Json
GoogleLocation
Json
Markdown
String
prisma/prisma-client-js#690MongoId
String
OEmbed
Json
Unsplash
Json
Wysiwyg
String