Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: converted Dropdown to a functional component utilizing react-popper #3179

Closed
wants to merge 7 commits into from

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Jun 17, 2020

As says. Includes a fix to withModalHandlers where mode wasn't being passed to the wrapped component.

Once there's a proper contextmenu usecase for Dropdown I'll be able to test whether that positioning works properly. I'm honestly not sure what that's supposed to look like. Because of the aforementioned bug with mode, the component was always using the contextmenu case in calculatePosition. That case is now handled with click, so I don't know what contextmenu is supposed to look like.

Includes some minor code cleanup to Popout.

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2020

🦋 Changeset is good to go

Latest commit: 163ca9a

We got this.

This PR includes changesets to release 7 packages
Name Type
@arch-ui/dropdown Patch
@arch-ui/modal-utils Patch
@arch-ui/popout Patch
@keystonejs/app-admin-ui Patch
@arch-ui/docs Patch
@keystonejs/fields-color Patch
@keystonejs/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stale
Copy link

stale bot commented Jan 15, 2021

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Jan 15, 2021
@stale stale bot removed the needs-review label Apr 8, 2021
@bladey
Copy link
Contributor

bladey commented Apr 8, 2021

Thanks for this PR @Vultraz.

Keystone 5 has officially moved into active maintenance mode as we push towards the next major new version Keystone Next, you can find out more information about this transition here.

In an effort to sustain the project going forward, we're cleaning up and closing old PRs such as this one.

However, you are welcome to create a PR under the Keystone 5 repository.

Please let me know if you have any questions.

@bladey bladey closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants