Arch: converted Dropdown to a functional component utilizing react-popper #3179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As says. Includes a fix to
withModalHandlers
wheremode
wasn't being passed to the wrapped component.Once there's a proper
contextmenu
usecase for Dropdown I'll be able to test whether that positioning works properly. I'm honestly not sure what that's supposed to look like. Because of the aforementioned bug withmode
, the component was always using thecontextmenu
case incalculatePosition
. That case is now handled withclick
, so I don't know whatcontextmenu
is supposed to look like.Includes some minor code cleanup to
Popout
.