List plugin improvement #3011
Merged
List plugin improvement #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: ed169f1 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced May 21, 2020
Closed
timleslie
suggested changes
May 21, 2020
|
@timleslie should be all good |
timleslie
suggested changes
May 22, 2020
gautamsi
force-pushed
the
list-plugins-make-keystone-and-list-key-accessible
branch
from
47a4617 to
e6ef199
Compare
timleslie
approved these changes
May 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2838
This is split from #2838 and works on single feature of adding additional parameter to list plugins.
additional parameter is
{listKey, keystone}name of the list helps in setting up further if want to build dynamic queries or logging.keystoneparameter further help add feature in plugin which may need keystone instance. for example some list author can create additional list or meta list.( I can think of a list history plugin which can create a list by name of
${listkey}Historyand use beforeChange/afterChange hooks to copy changed content to history list).best viewed whitespace off