Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin UI: restructured sidebar to made dev actions more noticeable #2798

Merged
merged 9 commits into from
Apr 28, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Apr 22, 2020

Resolves #1190 based on @jesstelford 's mockup. Open to suggestions as to the design, but I think it looks pretty good!

image

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2020

🦋 Changeset is good to go

Latest commit: 0ba50d9

We got this.

This PR includes changesets to release 2 packages
Name Type
@arch-ui/navbar Patch
@keystonejs/app-admin-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz
Copy link
Contributor Author

Vultraz commented Apr 22, 2020

I wonder if it would look better without the icons... 🤔 Thoughts?
image

@lucatk
Copy link

lucatk commented Apr 26, 2020

Quick question (also, the redesign looks really good I think!):
Currently, the sidebar does not have any background color, resulting in overlapping elements when List content ends up being wider than my browser window.

A quick fix would be adding a background color to the sidebar. I determined it would belong here:

<PrimaryNav
    onMouseEnter={handleMouseEnter}
    onMouseLeave={handleMouseLeave}
-   style={makeResizeStyles('width')}
+   style={{
+       ...makeResizeStyles('width'),
+       backgroundColor: colors.page,
+   }}
 >

I haven't worked out how to contribute with all the monorepo stuff and this being just a single line of code deemed it too much work to figure it out right now. Therefore, this PR seemed like a good place for that change (if the PR is going to be merged any time soon, otherwise a hotfix would be appreciated)

@timleslie
Copy link
Contributor

@Vultraz Are you able to follow up on the suggestion from @lucatk ? Let me know, I'll hold off merging this until you get back to me just so we don't lose the info.

@Vultraz
Copy link
Contributor Author

Vultraz commented Apr 27, 2020

@timleslie done 👍

@Vultraz
Copy link
Contributor Author

Vultraz commented Apr 27, 2020

How come Netlify is on the fritz today? 🤔

@timleslie timleslie merged commit 95babf5 into keystonejs:master Apr 28, 2020
@Vultraz Vultraz deleted the admin-ui-sidebar-revamp branch April 28, 2020 04:52
This was referenced Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GraphQL Playground link more obvious in AdminUI
4 participants