Cleaned up FieldDescription usage #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 00c7c50 We got this. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MadeByMike
suggested changes
Apr 19, 2020
There was a problem hiding this comment.
I like this! Strangely this is actually a breaking change for arch-ui as the FieldDescription no longer accepts children.
Pretty sure nobody is using it directly but, just in case, can we please add a description of changes required to fix this in the changeset description.
MadeByMike
reviewed
Apr 20, 2020
MadeByMike
reviewed
Apr 20, 2020
MadeByMike
approved these changes
Apr 20, 2020
|
Thanks! Sorry I didn't get to that yesterday. |
This was referenced Apr 20, 2020
Merged
Wkasel
pushed a commit
to gosignal/keystone
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing