-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded _ksListsMeta
query input to take a key list
#2715
Conversation
🦋 Changeset is good to goLatest commit: 769a7a4 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
84cd682
to
270f820
Compare
Added an aux filter param too: _ksListsMeta(where: { auxiliary: false }) |
_ksListsMeta
query input to take a key list_ksListsMeta
query input to take a key list, added aux filter
Async callback not invoked failure. |
Hmmm I'm less sure we need this one @Vultraz, not sure we needed the where either... 🤔 Isn't this exactly why GraphQL and not rest:
Why not make GraphQL the API? |
Originally, I was just implementing #1279 as @jesstelford requested. Admittedly, there is some benefit to being able to just pass in an array of list keys without manually constructing the query, but I'm not sure I'll actually need to use that. The |
Yep I want to get another opinion on adding the array. Writing a larger query is not too bad and you could write a helper to generate it if you needed it for huge amounts of lists. Up to you if you want to merge |
Split the |
_ksListsMeta
query input to take a key list, added aux filter_ksListsMeta
query input to take a key list
b260f2f
to
769a7a4
Compare
I think we arrived at not needing this. Closing. |
I was thinking more about the
where
input I added to_ksListsMeta
in #2664, and it occurred to me that that change was perhaps not the most useful. If you already know the key you want - for example,User
- you could just do a_UsersMeta
query instead of_ksListsMeta(where: { key: "User" })
.This expands
key
to accept an array, so as to be more versitile:gives
Though, admittedly, one could still just do...
So perhaps the
where
input still isn't that useful after all... 🤔 @jesstelford thoughts?