Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminUI] Field Oembed Iframely adapter: Can't pass optionnal parameters #2371

Closed
maximelebreton opened this issue Feb 15, 2020 · 2 comments
Closed

Comments

@maximelebreton
Copy link

Hello,

We should pass optionnal parameters to Iframely's adapter,

Like in this example:
https://iframely.com/embed/https%3A%2F%2Fsoundcloud.com%2Fluuuge%2Fno-mj?_hide_comments=true&_horizontal=true

We can specify:
_hide_comments=true&_horizontal=true

So we should do this:

const iframelyAdapter = new IframelyOEmbedAdapter({
  apiKey: "...", // Get one from https://iframely.com
  _hide_comments: true,
  _horizontal: true
});

But this is not the case.

Thanks!

@stale
Copy link

stale bot commented Jun 14, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Jun 14, 2020
@bladey
Copy link
Contributor

bladey commented Apr 8, 2021

Keystone 5 has officially moved into active maintenance mode as we push towards the next major new version Keystone Next, you can find out more information about this transition here.

In an effort to sustain the project going forward, we're cleaning up and closing old issues such as this one. If you feel this issue is still relevant for Keystone Next, please let us know.

@bladey bladey closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants