Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show 'tracking fields' #566

Closed
mjmaix opened this issue Aug 23, 2014 · 11 comments
Closed

Add option to show 'tracking fields' #566

mjmaix opened this issue Aug 23, 2014 · 11 comments
Assignees

Comments

@mjmaix
Copy link
Contributor

mjmaix commented Aug 23, 2014

Have an option to show tracking fields (createdAt, updatedAt, createdBy and updatedBy) in the Admin UI.

I'm planning to create PR for this.
For now I'm not sure w/c one is better

  1. having a separate List options showTrack : true or
  2. plug new option on the track object track: { createdAt: true, updatedAt: true, createdBy: true, updatedBy:true, showTrack: true}
@webteckie
Copy link
Contributor

Another approach may be to just individualize/objectize the tracking options so that multiple properties can be attached to it. For example:

updatedAt: { show: true, edit: true}

Not saying allowing editing of these makes sense (it could for some use case) but this is to demonstrate that each of these can be managed independently. Not sure how well this would play with the work @johnnyestilles did.

@estilles
Copy link

@mjmaix, that's a great suggestion for a PR. I actually have an implementation, but have been waiting until after the UI Admin Rewrite (#503) to submit a PR.

I like the idea of adding an option to track, that way all the tracking related options are in one place.

@webteckie, at the moment all the tracking fields are created by plugin (behind the scenes) with hidden set to true (see code here). So there's no way for the user to specify any options on the fields themselves. That said, I do like the idea of optionally enabling the showTrack option "per field". There are a number of ways we could implement this.

@JedWatson, is this something we should consider doing now or should we do it post-react?

@webteckie
Copy link
Contributor

@johnnyestilles not sure if that code referenced by that link is the latest but there seems to be a bug at this line:

// if all track fields are set to false, then user doesn't want to track anything
if (!options.createdAt && !options.createdBy && !options.updatedAt && !options.updatedAt) {
    return;
}

@estilles
Copy link

@webteckie, it is! Thanks for he catch. Submitting the correction in a few minutes.

@estilles
Copy link

Correction submitted (PR #569). Thanks again @webteckie.

@mjmaix
Copy link
Contributor Author

mjmaix commented Aug 23, 2014

@webteckie great suggestion, I was on the impression that per field modification is not good cause users would have to configure more.. but that's just me being lazy. I also agree that noedit should also be allowed to be user defiend and optional.

@JohnnyEstilles great (and thanks btw for the track feature), could you share the commit for the implementation?

@estilles
Copy link

@mjmaix my current implementation is outdated. It pre-dates the current track option by several months. I'm willing to invest some time updating it once we decide if the feature will be included pre- or post-react.

@mjmaix
Copy link
Contributor Author

mjmaix commented Aug 25, 2014

Thanks, will wait till then. :)

@morenoh149
Copy link
Contributor

was this fixed?

@creynders
Copy link
Contributor

AFAIK this is fixed, if not please reopen.

@JedWatson
Copy link
Member

It pretty much is, the UI could be nicer / better integrated, but that'll happen over the course of the next few updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants