Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in documentation #1296

Closed
cadwmaster opened this issue Apr 10, 2015 · 4 comments
Closed

Change in documentation #1296

cadwmaster opened this issue Apr 10, 2015 · 4 comments
Assignees

Comments

@cadwmaster
Copy link

On the documentation about the configuration of keystone (http://keystonejs.com/docs/configuration/) you point to check node-sass for the options when actually those options are passed to node-sass-middleware, you should link that library instead.

sass options Object  
    Optional config options that will be passed to the sass middleware; see github.com/sass/node-sass for more information.
@JedWatson
Copy link
Member

As I understand it, the options are passed directly through from node-sass-middleware to node-sass, so the best place to find the documentation reference is in the node-sass project itself.

Is that not the case?

@cadwmaster
Copy link
Author

Actually no, because the options are for node-sass-middleware, as you can see in the keystone file: /lib/core/mount.js

        app.use(sassMiddleware(_.extend({
            src: this.expandPath(value),
            dest: this.expandPath(value),
            outputStyle: this.get('env') === 'production' ? 'compressed' : 'nested'
        }, sassOptions)));

and then if you follow the code of node-sass-middleware the options passed to the middleware are used only there and never sent to node-sass

@creynders
Copy link
Contributor

@cadwmaster yes, that definitely does seem to be the case.

@mxstbr
Copy link
Collaborator

mxstbr commented Apr 29, 2016

Moved to keystonejs-site: keystonejs/keystonejs-site#109

@mxstbr mxstbr closed this as completed Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants