Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Turbo to 2.3.1 #564

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

yetanotheraryan
Copy link
Contributor

@yetanotheraryan yetanotheraryan commented Nov 26, 2024

User description

Description

updated the turbo package and made the required changes in turbo.json

Fixes #542

Mentions

@rajdip-b


PR Type

enhancement, configuration changes


Description

  • Updated the turbo package in package.json to version ^2.3.1.
  • Modified turbo.json configuration to replace pipeline with tasks and adjusted task inputs for compatibility with the new version.

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Update turbo package to latest version                                     

package.json

  • Updated turbo package version from ^1.12.4 to ^2.3.1.
+1/-1     
Configuration changes
turbo.json
Update turbo configuration for compatibility                         

turbo.json

  • Changed pipeline key to tasks.
  • Modified env to inputs for the build task.
  • +3/-3     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis 🔶

    542 - Partially compliant

    Compliant requirements:

    • Turbo package was updated to latest version (^2.3.1)
    • Configuration was updated to match new version requirements

    Non-compliant requirements:

    • No explicit verification/testing mentioned to ensure scripts weren't broken
    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Validation
    Verify that the change from 'env' to 'inputs' for NEXT_PUBLIC_BACKEND_URL doesn't break environment variable handling

    Breaking Change
    Validate that the pipeline to tasks migration maintains all previous build configurations and dependencies

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @yetanotheraryan yetanotheraryan changed the title turbo updated and neccessary changes done tchore!: Update Turbo to 2.3.1 Nov 26, 2024
    @yetanotheraryan yetanotheraryan changed the title tchore!: Update Turbo to 2.3.1 chore: Update Turbo to 2.3.1 Nov 26, 2024
    @rajdip-b rajdip-b merged commit 3a63823 into keyshade-xyz:develop Nov 27, 2024
    2 checks passed
    rajdip-b pushed a commit that referenced this pull request Dec 3, 2024
    ## [2.8.0](v2.7.0...v2.8.0) (2024-12-03)
    
    ### 🚀 Features
    
    * **api:** Add workspace removal notification email template ([#476](#476)) ([40b754f](40b754f))
    * **cli:** Store `metrics_enabled` key in profile config ([#536](#536)) ([9283b22](9283b22))
    * **package, api, cli:** Add api-key schemas and types; Fix schema inconsistencies; Minor fix for CLI build errors  ([#557](#557)) ([126d024](126d024))
    * **platform:** Added screen for CREATE NEW PROJECT ([#540](#540)) ([b644633](b644633))
    * **platform:** Updated the empty state of dashboard ([#522](#522)) ([28739d9](28739d9))
    * **schema, api-client:** Migrate auth types to @keyshade/schema ([#532](#532)) ([d880098](d880098))
    * **schema, api-client:** Migrate event schemas and types to @keyshade/schema ([#546](#546)) ([a3267de](a3267de))
    * **schema, api-client:** Migrate integration schemas and types to @keyshade/schema ([#547](#547)) ([08868c3](08868c3))
    * **schema, api-client:** Migrate project schemas and environment schemas along with their types to @keyshade/schema ([#538](#538)) ([c468af0](c468af0))
    * **schema, api-client:** Migrate [secure] types and schemas to @keyshade/schema ([#539](#539)) ([bc3100b](bc3100b))
    * **schema, api-client:** Migrate user types and schemas to @keyshade/schema ([#535](#535)) ([c24695e](c24695e))
    * **schema, api-client:** Migrate variable schemas and types to @keyshade/schema ([#545](#545)) ([0ee8f9a](0ee8f9a))
    * **schema, api-client:** Migrate workspace-membership schemas and types to @keyshade/schema ([#569](#569)) ([4398969](4398969))
    * **schema, api-client:** Migrate workspace-role schemas and types to @keyshade/schema ([#568](#568)) ([9efbf2d](9efbf2d))
    * **schema:** Add User type inference from UserSchema ([#574](#574)) ([84c1db5](84c1db5))
    
    ### 🐛 Bug Fixes
    
    * **api:** Incorrect oauth redirect url ([58d96e5](58d96e5))
    * **platform:** Resolve loading SVG blocking input field interaction ([#571](#571)) ([30f4f65](30f4f65))
    
    ### 📚 Documentation
    
    * Add pictures to Bruno setup ([#541](#541)) ([210c0fd](210c0fd))
    * Migrate to Bruno ([#525](#525)) ([1793d92](1793d92))
    
    ### 🔧 Miscellaneous Chores
    
    * **ci:** Add script to validate schema package ([59e4280](59e4280))
    * Fixed codecov client version ([a998ae4](a998ae4))
    * **package:** Fixed tests and did housekeeping ([#544](#544)) ([40008e3](40008e3))
    * Update test coverage settings ([5b27e32](5b27e32))
    * Update Turbo to 2.3.1 ([#564](#564)) ([3a63823](3a63823))
    * **web:** Update dockerfile ([10d9cc5](10d9cc5))
    
    ### 🔨 Code Refactoring
    
    * **api-client, schema:** Add workspace's schemas and types in @keyshade/schema ([#520](#520)) ([7c8ee5d](7c8ee5d))
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    chore: Update turbo to latest version
    2 participants