Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM: Replace using raw calls with API Client package #513

Open
rajdip-b opened this issue Oct 28, 2024 · 16 comments
Open

PLATFORM: Replace using raw calls with API Client package #513

rajdip-b opened this issue Oct 28, 2024 · 16 comments
Labels
difficulty: 3 good first issue Good for newcomers priority: high scope: platform Everything related to the keyshade platform package type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

Description

The platform app is still using raw calls to the API. We have a dedicated API Client package for this purpose. We would like to replace the current calls with this.

Solution

You can refer to how we utilize API Client in our CLI package.

@rajdip-b rajdip-b added good first issue Good for newcomers type: chore Release drafter tag for tagging PRs related to making patches to general code scope: platform Everything related to the keyshade platform package priority: high difficulty: 3 labels Oct 28, 2024
@Prakhargarg-2010196
Copy link
Contributor

Can I next pick it up @rajdip-b ?

@rajdip-b
Copy link
Member Author

rajdip-b commented Nov 5, 2024

Yes absolutely.

@Prakhargarg-2010196
Copy link
Contributor

/attempt

Copy link

github-actions bot commented Nov 5, 2024

Assigned the issue to @Prakhargarg-2010196!

@kriptonian1
Copy link
Contributor

@Prakhargarg-2010196 are you still working on this issue ?

@Prakhargarg-2010196
Copy link
Contributor

I have marked the todos would try to do this on weekend was bit busy with job

@rajdip-b
Copy link
Member Author

sure sure

@Prakhargarg-2010196
Copy link
Contributor

@rajdip-b can you tell me what was decided for where the baseurl would be passed on the frontend side for the api-client.

@rajdip-b
Copy link
Member Author

The base url would be set in the platform app's NEXT_PUBLIC_BASE_URL field. You can use that. As for how it needs to be implemented, you would need to initialize the ControllerInstance in some sort of a provider (refer to jotai docs). You can also look up how the cli app does it.

@Prakhargarg-2010196
Copy link
Contributor

As for how it needs to be implemented, you would need to initialize the ControllerInstance in some sort of a provider (refer to jotai docs). You can also look up how the cli app does it.

That I had already checked and asked you about and you said @kriptonian1 to look into it that's why I asked about it. Conversation

@kriptonian1
Copy link
Contributor

As for how it needs to be implemented, you would need to initialize the ControllerInstance in some sort of a provider (refer to jotai docs). You can also look up how the cli app does it.

That I had already checked and asked you about and you said @kriptonian1 to look into it that's why I asked about it. Conversation

Script is basically for adding script, and it can't be used as a replacement of a state management tool, I will recommend going with jotai

@Prakhargarg-2010196
Copy link
Contributor

okay

As for how it needs to be implemented, you would need to initialize the ControllerInstance in some sort of a provider (refer to jotai docs). You can also look up how the cli app does it.

That I had already checked and asked you about and you said @kriptonian1 to look into it that's why I asked about it. Conversation

Script is basically for adding script, and it can't be used as a replacement of a state management tool, I will recommend going with jotai

Okay let me check what I can do.

@kriptonian1
Copy link
Contributor

@Prakhargarg-2010196 are you still working on this issue?

@Prakhargarg-2010196
Copy link
Contributor

Prakhargarg-2010196 commented Nov 26, 2024

I am but not getting much time due to starting of new job. If its urgent then you can unsassign I will pick some other issue sometime maybe.

Moreover not able to figure out a way to call that instance in jotai.

@rajdip-b
Copy link
Member Author

Hey buddy, don't mind, but we are unassigning you for now since this is a bit important to us. Feel free to take up other issues as and when you can.

P.S. congrats for getting a new job!

@Prakhargarg-2010196
Copy link
Contributor

Hey buddy, don't mind, but we are unassigning you for now since this is a bit important to us. Feel free to take up other issues as and when you can.

P.S. congrats for getting a new job!

Yeah sure!
Thanks @rajdip-b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 3 good first issue Good for newcomers priority: high scope: platform Everything related to the keyshade platform package type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
None yet
Development

No branches or pull requests

3 participants