Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Replace sleep command with OS-specific command #506

Open
rajdip-b opened this issue Oct 21, 2024 · 11 comments · May be fixed by #523
Open

API: Replace sleep command with OS-specific command #506

rajdip-b opened this issue Oct 21, 2024 · 11 comments · May be fixed by #523
Assignees
Labels
difficulty: 3 hacktoberfest Hacktoberfest is on! help wanted Extra attention is needed priority: urgent scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

Description

"e2e:prepare": "cd ../../ && docker compose down && docker compose -f docker-compose-test.yml up -d && sleep 3 && cd apps/api && pnpm db:generate-types && cross-env NODE_ENV='e2e' DATABASE_URL='postgresql://prisma:prisma@localhost:5432/tests' pnpm run db:deploy-migrations",

The script uses the sleep command. We would like to replace it to use an OS specific sleep command.

@rajdip-b rajdip-b added help wanted Extra attention is needed scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code priority: urgent difficulty: 3 hacktoberfest Hacktoberfest is on! labels Oct 21, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Oct 21, 2024
@career-yashaswee
Copy link

career-yashaswee commented Oct 21, 2024

/assign

Copy link

Assigned the issue to @rothardo!

@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Oct 23, 2024
@Allan2000-Git
Copy link
Contributor

/assign

@rajdip-b
Copy link
Member Author

rajdip-b commented Nov 1, 2024

@career-yashaswee are you still on this?

@rajdip-b
Copy link
Member Author

rajdip-b commented Nov 5, 2024

@Allan2000-Git any progress?

@rajdip-b rajdip-b moved this from In progress to Todo in keyshade-api Nov 5, 2024
@Allan2000-Git
Copy link
Contributor

@rajdip-b I thought @career-yashaswee was working on this. Will raise a PR soon.

@rajdip-b
Copy link
Member Author

rajdip-b commented Nov 6, 2024

I think you can pick it up

@Allan2000-Git
Copy link
Contributor

@rajdip-b Can I use node dist/common/cross-platform-sleep.js 3 ?
Do I have to install package like ts-node to compile to javascript or will it be taken from dist folder ?

@rajdip-b
Copy link
Member Author

rajdip-b commented Nov 7, 2024

I'm not sure why you would use JS in the first place

@Allan2000-Git
Copy link
Contributor

file is typescript file, but we will have to compile to js right as it cannot understand ts file

@rajdip-b
Copy link
Member Author

rajdip-b commented Nov 7, 2024

Hmm, that kinda makes sense. But maybe you can look up some npm package? I'm sure there must be one.

@Allan2000-Git Allan2000-Git linked a pull request Nov 8, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 3 hacktoberfest Hacktoberfest is on! help wanted Extra attention is needed priority: urgent scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants