Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Swap the testing db with SQLite #333

Open
rajdip-b opened this issue Jul 8, 2024 · 7 comments
Open

API: Swap the testing db with SQLite #333

rajdip-b opened this issue Jul 8, 2024 · 7 comments
Assignees
Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers priority: low scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Jul 8, 2024

Description

We want to swap out our Postgres database in docker compose file to SQLite. This will improve the E2E execution speed

db:
image: postgres:13
restart: always
container_name: integration-tests-prisma
ports:
- '5432:5432'
environment:
POSTGRES_USER: prisma
POSTGRES_PASSWORD: prisma
POSTGRES_DB: tests
networks:
- keyshade-test

Solution

  • Remove the db service in docker-compose-test.yml
  • Update schema.prisma to be compatible with Prisma SQLite
@rajdip-b rajdip-b added good first issue Good for newcomers scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code priority: low foss hack Clustering all the curated issues for Foss Hack 2024 difficulty: 2 labels Jul 8, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Jul 8, 2024
@vr-varad
Copy link
Contributor

/attempt

Copy link

Assigned the issue to @vr-varad!

@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Jul 17, 2024
@MelloB1989
Copy link

/attempt

Copy link

Assigned the issue to @MelloB1989!

@rajdip-b
Copy link
Member Author

Hey @MelloB1989! Unfortunately I can't assign this issue to you since @vr-varad has already been assigned to this. Only if @vr-varad thinks that he wants to drop his attempt, can I assign you.

@vr-varad
Copy link
Contributor

Sorry I haven't made a pr but has worked on it. @rajdip-b thought would make in fosshack weekend.
Should I make a pr?

@rajdip-b
Copy link
Member Author

No, hold on to that. Otherwise it won't be considered for the hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers priority: low scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
Status: In progress
Development

No branches or pull requests

3 participants