Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Get the email to send feedbacks to from process.env #235

Closed
rajdip-b opened this issue May 22, 2024 · 5 comments · Fixed by #236
Closed

API: Get the email to send feedbacks to from process.env #235

rajdip-b opened this issue May 22, 2024 · 5 comments · Fixed by #236
Assignees
Labels
good first issue Good for newcomers priority: low scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

Description

It would be a good practice to keep things dynamic so that the code can be easily configured without making any code changes. We would like to parse the email, where we want to send the feedbacks sent by the users, from process.env.

Solution

  • Create an environmental variable named FEEDBACK_FORWARD_EMAIL
  • Add it in .env.example
  • Add it in zod schema
@rajdip-b rajdip-b added good first issue Good for newcomers scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code priority: low labels May 22, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api May 22, 2024
@Princeyadav05
Copy link
Contributor

Hi @rajdip-b , Can i try this issue? Seems a pretty easy one.
I'm confident I would be able to solve this.

@rajdip-b
Copy link
Member Author

Sure thing dude! Here you go

@Princeyadav05
Copy link
Contributor

@rajdip-b have created a PR with the fix. LMK if anything needs to be changed.

@rajdip-b
Copy link
Member Author

Awesome! I'll review it whenever I'm free again.

@github-project-automation github-project-automation bot moved this from In progress to Done in keyshade-api May 23, 2024
@rajdip-b rajdip-b moved this from Done to Queued for release in keyshade-api May 23, 2024
@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rajdip-b rajdip-b moved this from Queued for release to Done in keyshade-api May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority: low scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants