Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General refactors - Icons restructure #185

Open
4 of 5 tasks
tzeweiwee opened this issue Mar 14, 2023 · 0 comments
Open
4 of 5 tasks

General refactors - Icons restructure #185

tzeweiwee opened this issue Mar 14, 2023 · 0 comments
Assignees
@tzeweiwee @andrehadianto

Comments

@tzeweiwee
Copy link
Contributor

tzeweiwee commented Mar 14, 2023 •
edited
Loading

Describe the problem

  • Abstract Icons to one Icon component, improves DX but make sure tree shaking still applies

  • Better naming conventions

    • My Near to My Near Wallet . Same for camelCase.
    • Gift claim page, too generic

  • Scan through utils and remove toYocto

  • add cache control to getDropInformation with 5 seconds validity, store drop info and timestamp in local storage, compare timestamp and revalidate

  • Add comments to Buttons component to improve readability
@andrehadianto andrehadianto mentioned this issue Mar 15, 2023
Merged
2 tasks
@tzeweiwee tzeweiwee mentioned this issue Mar 28, 2023
Merged
@tzeweiwee tzeweiwee changed the title General refactors General refactors - Icons restructure Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzeweiwee tzeweiwee

@andrehadianto andrehadianto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

andrel/185-general-refactors keypom/keypom-frontend
2 participants
@tzeweiwee @andrehadianto