Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(android): "Always show banner" has no effect #12376

Closed
ermshiperete opened this issue Sep 9, 2024 · 1 comment · Fixed by #12430
Closed

bug(android): "Always show banner" has no effect #12376

ermshiperete opened this issue Sep 9, 2024 · 1 comment · Fixed by #12430
Assignees
Milestone

Comments

@ermshiperete
Copy link
Contributor

ermshiperete commented Sep 9, 2024

With the "Always show banner" option turned off, the banner will still show (with the Keyman logo), regardless of the "Enable predictions" setting for the current language, and regardless of whether or not a dictionary for the current language is installed.

If "Always show banner" is off, we shouldn't show the banner if a) "Enable predictions" is off, or b) there are no dictionaries installed for the language.

Screenshot_2024-09-09-08-45-18-55_958d350bfbdeb289302c75fe5c4a9384

@darcywong00
Copy link
Contributor

ah yes - this came from 17.0 where there will always either be a suggestion banner or an image banner for the top-row longpress keys.

We can clarify the strings as part of revamping that menu in #12203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants