Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions: Date Driver Update Released / Date Patch Added Columns / Autoupdate Improvement / Error Message Improvement / File Ownership Merge Request #854

Open
Spaatz1402 opened this issue Oct 11, 2024 · 2 comments · May be fixed by #881
Labels

Comments

@Spaatz1402
Copy link

Spaatz1402 commented Oct 11, 2024

Hello,

I love your tool but find it a bit daunting to determine when I last applied the patch and would like to save some time researching all of that before simply applying the latest patch.

Here are some suggestions I feel would be good for your application:

1.) The error message when trying to reapply the patch could be updated to indicate the patch has already been applied.
2.) The file ownership rights issue should be pushed to the main version because nearly all files I'm getting from NVidia these days are locked for editing until I take ownership and thus this installer fails. I'm using a forked version of this tool that has the functionality required. Perhaps merge that functionality? Win_1337_Apply_Patch_v2.1_By_DFoX
3.) The documentation screen / table which lists the patches, driver link, version number, etc. could have two additional columns:
A.) Date patch made available
B.) Date of Driver Release
4.) Adding an automatic update feature to the application to identify the correct patch needed, download the update from GitHub and apply it to the driver would be ideal.

Thanks for taking the suggestions into consideration and thanks for your work!

@ramhaidar
Copy link
Contributor

Thank you for your suggestions @Spaatz1402! Here is my response regarding the suggestions you provided:

  1. This is a great idea, and I will implement it in the forked version of my application if I have some free time later.
  2. Regarding your merge suggestion, I have actually submitted a PR to the main Win_1337_Apply_Patch repository, and Deltafox79 has merged it into the main master branch. However, it seems that they either forgot or were too busy to upload the latest release of the modified code. So, as long as they haven't updated it, you can use a forked version with updated functionality to handle it.
  3. and 4. I have no comments on these points; I will leave them to the other maintainers for further discussion.

@ramhaidar
Copy link
Contributor

Hello @Spaatz1402,

I am pleased to inform you that the feature requested in Point 1 has been successfully implemented. The error message displayed when attempting to reapply a patch now clearly indicates if the patch has already been applied. This improvement is available in the latest release, v2.2, which can be downloaded here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants