parse._parsedParameters: do not use helpers.unescapedIndexOf() #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Sep 18, 2022
iCalendar and vCard parameters do not use \ as escape character in the property parameter values, hence cn="\"X" is not a quote X, but invalid. The proper escape character is ^ per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to kewisch#536
dilyanpalauzov
force-pushed
the
parse_parameters_unescapedIndexOf
branch
from
7d4eccc to
aafdcb7
Compare
Pull Request Test Coverage Report for Build 8676396508Details
💛 - Coveralls |
dilyanpalauzov
force-pushed
the
parse_parameters_unescapedIndexOf
branch
from
aafdcb7 to
53a918d
Compare
|
Now updated to ES6. |
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Nov 29, 2022
iCalendar and vCard parameters do not use \ as escape character in the property parameter values, hence cn="\"X" is not a quote X, but invalid. The proper escape character is ^ per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to kewisch#536 ES6-ready
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Nov 29, 2022
iCalendar and vCard parameters do not use \ as escape character in the property parameter values, hence cn="\"X" is not a quote X, but invalid. The proper escape character is ^ per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to kewisch#536
Closed
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Apr 13, 2024
iCalendar and vCard parameters do not use \ as escape character in the property parameter values, hence cn="\"X" is not a quote X, but invalid. The proper escape character is ^ per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to kewisch#536 ES6-ready
iCalendar and vCard parameters do not use \ as escape character in the property parameter values, hence cn="\"X" is not a quote X, but invalid. The proper escape character is ^ per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to
kewisch
force-pushed
the
parse_parameters_unescapedIndexOf
branch
from
53a918d to
9c85b29
Compare
kewisch
approved these changes
Apr 13, 2024
Closed
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Apr 20, 2024
iCalendar and vCard parameters do not use \ as escape character in the property parameter values, hence cn="\"X" is not a quote X, but invalid. The proper escape character is ^ per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to kewisch#536 ES6-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iCalendar and vCard parameters do not use
\as escape character in the property parameter values, hencecn="\"X"is not a quote X, but invalid. The proper escape character is^per RFC 6868. This change replaces helpers.unescapedIndexOf(x,…) with x.indexOf(…) in order not to count\as escape character.