Sort byparts before setting defaults in iterator #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think this makes sense. Can you rebase on master? There were some conflicts in recur_iterator.js |
kewisch
reviewed
Oct 6, 2019
| this.last.month = this.setup_defaults("BYMONTH", "MONTHLY", this.dtstart.month); | ||
|
|
||
| //setting day after month, as sorting BYMONTHDAY will differ based on the month |
There was a problem hiding this comment.
If sorting bymonthday differs based on month, wouldn't we need to sort this differently every month while the rule is iteraed?
|
It looks like we haven't heard back on this issue, therefore we are closing this issue. If this problem persists in the latest version of ical.js, please re-open this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mozilla-comm/ical.js/blob/master/lib/ical/recur_iterator.js#L1372
setup_defaults is returning the first element of bypart array, if the input bypart array are not sorted then the iteration is not always correct. In this PR i'm sorting the bypart arrays before calling setup_defaults. This also fixes #336