fix(parse): singleValue after multiValue parameter

Fixes #386.
kewisch · Jan 13, 2020 · 0ee23fc · 0ee23fc
1 parent f8174e8
commit 0ee23fc
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/lib/ical/parse.js b/lib/ical/parse.js
@@ -345,6 +345,8 @@ ICAL.parse = (function() {
         throw new ParserError("Empty parameter name in '" + line + "'");
       }
       lcname = name.toLowerCase();
+      mvdelim = false;
+      multiValue = false;
 
       if (lcname in designSet.param && designSet.param[lcname].valueType) {
         type = designSet.param[lcname].valueType;

diff --git a/test/parse_test.js b/test/parse_test.js
@@ -210,6 +210,32 @@ suite('parserv2', function() {
         expected
       );
     });
+
+    test('with comma in singleValue parameter', function() {
+      var input = ';LABEL="A, B"';
+      var expected = {
+        'label': 'A, B'
+      };
+
+      assert.deepEqual(
+        subject._parseParameters(input, 0, ICAL.design.components.vcard)[0],
+        expected
+      );
+    });
+
+    test('with comma in singleValue parameter after multiValue parameter', function() {
+      // TYPE allows multiple values, whereas LABEL doesn't.
+      var input = ';TYPE=home;LABEL="A, B"';
+      var expected = {
+        'type': 'home',
+        'label': 'A, B'
+      };
+
+      assert.deepEqual(
+        subject._parseParameters(input, 0, ICAL.design.components.vcard)[0],
+        expected
+      );
+    });
   });
 
   test('#_parseMultiValue', function() {