Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom Notifications? #120

Open
zakajd opened this issue Oct 20, 2024 · 2 comments
Open

Support for custom Notifications? #120

zakajd opened this issue Oct 20, 2024 · 2 comments

Comments

@zakajd
Copy link

zakajd commented Oct 20, 2024

Hi, thanks for amazing library

I'm using Helius RPC provider and they implemented a custom "transactionSubscribe" websocket message.
https://docs.helius.dev/webhooks-and-websockets/enhanced-websockets#standard-websockets

But I couldn't find a way to properly patch the python parser to handle those messages. Maybe provide a way to define custom classes as addition to standard Notification's?

@Morgandri1
Copy link
Contributor

Hey @zakajd
Because Helius is its own entity seperate from the remainder of the network, it doesn't necessarily make sense to implement their custom messages in this library. however, there are 2 good options for implementation i see:

  1. if @kevinheavey wants, i'd be more than happy to open a quick PR with a rust feature flag for Helius messages, although i'm not sure how that translates to python packages.
  2. other option is to fork the solders repo and just add the messages, then you'll have essentially a full Helius SDK in python.

@kevinheavey
Copy link
Owner

kevinheavey commented Nov 11, 2024

Yeah I don't think it's a good idea to open the can of worms that is adding third party types. Maybe just parse it with the Python json module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@zakajd @kevinheavey @Morgandri1 and others