Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobrew-windows-arm64.exe #187

Closed
gedw99 opened this issue Mar 6, 2024 · 16 comments
Closed

gobrew-windows-arm64.exe #187

gedw99 opened this issue Mar 6, 2024 · 16 comments

Comments

@gedw99
Copy link
Contributor

gedw99 commented Mar 6, 2024

Using the README instruction, I open a cmd shell on windows arm64 and put in:

Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/kevincobain2000/gobrew/master/git.io.ps1'))


Unable to find a valid release URL!
Unable to match OS: windows, CPU: arm64
Please open an issue at: https://github.com/kevincobain2000/gobrew/issues
Remember to provide your OS, CPU details and powershell version.

[process exited with code 1 (0x00000001)]
You can now close this terminal with Ctrl+D, or press Enter to restart.

This is what I get on windows arm64

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 6, 2024

if you turn off this https://github.com/kevincobain2000/gobrew/blob/master/.goreleaser.yaml#L20, then I can test it on windows 11 arm64 ...

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 6, 2024

@kevincobain2000
Copy link
Owner

Thanks.
I am totally clueless when it comes to windows. And could never understand why would someone not use wsl.

I’d have to take your word for it. And if the new changes don’t impact current Unix based systems then it’s ok. Feel free to submit the desired changes for windows only.

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 8, 2024

I will have to fork and test the whole CI / CD thing to make sure it works without creating any regressions.

If you get time have a crack at it. It's only 3 or 4 lines changes. Otherwise I will fork and try the whole cycle.

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 8, 2024

wsl

Some users just can't because of architectural constraints on their desktops in certain Orgs where they lock down their desktops.

I use gobrew to get golang onto end users desktops so that other code can use it for dynamic compilation

@kevincobain2000
Copy link
Owner

That’s sad.
anyways you can fork and push your changes. This repo runs the ci on forks too. Feel free to commit many times.

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 9, 2024

Ok that makes it easier . I did not want to presume. Will give it a try. Will take a few tries I expect

@gedw99
Copy link
Contributor Author

gedw99 commented Apr 1, 2024

also add arm64 here: https://github.com/kevincobain2000/gobrew/blob/master/git.io.ps1#L33

hey @kevincobain2000

$archMap = @{
    "amd64" = "x86_64", "i386_64"
    "386"   = "i386", "i686", "x86"    
  }

I have no idea what are the names for the extra mapping that we need to add to represent Windows arm 64. I am hoping you might know ?

@gedw99
Copy link
Contributor Author

gedw99 commented Apr 1, 2024

https://go.dev/doc/install shows that there are no golang builds for windows arm64.

so even if I get this issue working there are no golang builds that it can map to and download.

@gedw99
Copy link
Contributor Author

gedw99 commented Apr 2, 2024

https://go.dev/doc/install shows that there are no golang builds for windows arm64.

so even if I get this issue working there are no golang builds that it can map to and download.

I was wrong. There are golang installers for windows arm64. I tried it and it works fine.

That GOOS and GOARCH is just not what they call a First Class one.

https://go.dev/dl/go1.22.1.windows-arm64.zip

From web page: https://go.dev/dl/

@gedw99
Copy link
Contributor Author

gedw99 commented Apr 2, 2024

@kevincobain2000

could we reopen this please ? Go installers do exist as I pointed out above.

@gedw99
Copy link
Contributor Author

gedw99 commented Apr 2, 2024

also https://github.com/kevincobain2000/gobrew/blob/master/.github/workflows/release.yml can't be triggered by me, to see if the build worked for Windows ARM64 ?

@kevincobain2000
Copy link
Owner

Those will only work when @juev or me push new tag

@gedw99
Copy link
Contributor Author

gedw99 commented Apr 2, 2024

other can force an action too using dispatch workflow, but you need to add this to the workflows.

https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow

@kevincobain2000
Copy link
Owner

I know

@kevincobain2000
Copy link
Owner

Stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants