Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the purpose of this code in _embed_clip_tiles method? #71

Open
Shiva-Gantha opened this issue Jan 24, 2024 · 1 comment
Open

Comments

@Shiva-Gantha
Copy link

What is the use or purpose of the following lines, which is apparently copying the last column and row of the embedding matrix and repeating it?
clip_embeds = torch.concat((clip_embeds, clip_embeds[:, [-1], :]), dim=1)
clip_embeds = torch.concat((clip_embeds, clip_embeds[[-1], :, :]), dim=0)

Link to the code: https://github.com/kerrj/lerf/blob/4a13f2074f3f3a162d9b3b9e6c4bbcc21499a7f2/lerf/data/utils/patch_embedding_dataloader.py#L114C9-L115C82

@smileyenot983
Copy link

@Shiva-Gantha Hello, have you figured out the purpose of these 2 lines? I am wondering why where the last column and row of clip feature cloned. Observed same thing while working with LEGAUSSIANS and came here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants