Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample_weight is a misnomer #9118

Closed
caugusta opened this issue Jan 18, 2018 · 1 comment
Closed

Sample_weight is a misnomer #9118

caugusta opened this issue Jan 18, 2018 · 1 comment

Comments

@caugusta
Copy link

caugusta commented Jan 18, 2018

There seems to be a lot of confusion around sample_weight and sample_weight_mode (e.g 2594, 7120, 7497). As explained elsewhere, these apply a weight on the loss, which means if sample_weight_model=temporal then you should have 3D outputs. However, the name 'sample_weight' implies a weight on the samples, which is not what's happening. Should the name be changed? Is there a way to weight the actual samples instead of the loss based on the samples?

@FitMachineLearning
Copy link

I second that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants