Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix: Improve Data explorer unit support #959

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

arthurpitman
Copy link
Collaborator

This PR improves support for units in Data explorer tiles:

  • Adds support for unit None
  • Omits conversion when no conversion is required

j-poecher
j-poecher previously approved these changes Nov 14, 2022
Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

The following Docker Images have been built:
keptncontrib/dynatrace-service:0.24.1-dev-PR-959,keptncontrib/dynatrace-service:0.24.1-dev-PR-959.202211141306

Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurpitman arthurpitman merged commit 6fa0e94 into master Nov 15, 2022
@arthurpitman arthurpitman deleted the fix/improve-data-explorer-unit-support branch November 15, 2022 06:42
This was referenced Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants