Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

feat!: Do not create dynatrace/sli.yaml when retrieving SLIs from a dashboard #866

Merged
merged 36 commits into from
Aug 3, 2022
Merged

feat!: Do not create dynatrace/sli.yaml when retrieving SLIs from a dashboard #866

merged 36 commits into from
Aug 3, 2022

Conversation

arthurpitman
Copy link
Collaborator

@arthurpitman arthurpitman commented Jul 22, 2022 •
edited
Loading

This PR [breaking change!]:

  • removes code that creates dynatrace/sli.yaml when retrieving SLIs from a dashboard
  • adds code that puts the API query used to obtain each SLI in the query field of the associated indicatorValue in the sh.keptn.event.get-sli.finished event

Most effort of the PR is for updating tests, but it also simplifies code paths.

Closes #593

@arthurpitman arthurpitman marked this pull request as draft July 22, 2022 11:34
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from fcade9e to cb16ac1 Compare July 22, 2022 12:10
@arthurpitman
Try to reduce complexity
46bc5f1 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Use base SLI query
4c66174 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from c87d5f4 to 4c66174 Compare July 22, 2022 13:13
@arthurpitman
Clean up assertions
d50dc91 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Move common functions
51b2da4 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Simplify test logic
72ab596 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Simplify tests
d5dfa09 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Fix messages in mock
8e66d27 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from e22f9c6 to 55d161f Compare July 28, 2022 15:24
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from 55d161f to d001480 Compare July 29, 2022 11:54
@arthurpitman
Rename createSuccessfulDashboardSLIResultAssertionsFunc to `createS…
829e7d0 
…uccessfulSLIResultAssertionsFunc`

Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Polish tests
5f78d14 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Switch to client request strings for file-based metrics queries
5e91b28 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Switch to client request strings for file-based SECPV2 queries
432b777 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Switch to client request strings for file-based PV2 queries
fd54bc3 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Switch to client request strings for file-based SLO queries
bec85b8 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Switch to client request strings for file-based USQL queries
999e469 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from 3b63f89 to 999e469 Compare July 30, 2022 21:46
@arthurpitman
Remove unneeded function
cd74fe3 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Documentation update
78d8a7c 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman marked this pull request as ready for review August 1, 2022 07:47
@arthurpitman
Fix test
6de6da9 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from f6613d0 to 6de6da9 Compare August 1, 2022 11:43
@arthurpitman arthurpitman force-pushed the feature/593/dont-create-sli-yaml-for-dashboards branch from cf1d773 to 95c21c0 Compare August 2, 2022 12:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 27 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

The following Docker Images have been built:
keptncontrib/dynatrace-service:0.23.1-dev-PR-866,keptncontrib/dynatrace-service:0.23.1-dev-PR-866.202208021223

j-poecher
j-poecher approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurpitman arthurpitman merged commit c90efc2 into master Aug 3, 2022
@arthurpitman arthurpitman deleted the feature/593/dont-create-sli-yaml-for-dashboards branch August 3, 2022 10:28
This was referenced Oct 25, 2022
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-poecher j-poecher j-poecher approved these changes

@agrimmer agrimmer Awaiting requested review from agrimmer agrimmer is a code owner

@heckelmann heckelmann Awaiting requested review from heckelmann

@hubmat00 hubmat00 Awaiting requested review from hubmat00

@jskelin jskelin Awaiting requested review from jskelin

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLI.yaml should not be created for SLIs created from a dashboard
2 participants
@arthurpitman @j-poecher