Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

feat: send evaluation finished events to PGI level #822

Merged
merged 12 commits into from
Jun 13, 2022

Conversation

j-poecher
Copy link
Contributor

closes #240

evaluation finished events will now be sent to PGIs that belong to a certain SERVICE tagged with keptn_project, keptn_stage and keptn_service and have a certain version.

@@ -39,3 +46,92 @@ func getValueFromLabels(a adapter.EventContentAdapter, key string, defaultValue
}
return defaultValue
}

type KeptnContext interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type KeptnContext should have comment or be unexported

}
}

type TimeframeFunc func() (*common.Timeframe, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type TimeframeFunc should have comment or be unexported

internal/common/image_and_tag.go Outdated Show resolved Hide resolved
@@ -78,3 +81,39 @@ func (ec *EntitiesClient) GetKeptnManagedServices(ctx context.Context) ([]Entity
}
return entities, nil
}

type PGIQueryConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type PGIQueryConfig should have comment or be unexported

"testing"
)

type FileBasedURLHandlerWithSink struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type FileBasedURLHandlerWithSink should have comment or be unexported

sink map[string][]byte
}

func NewFileBasedURLHandlerWithSink(t *testing.T) *FileBasedURLHandlerWithSink {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported function NewFileBasedURLHandlerWithSink should have comment or be unexported

}
}

func (h *FileBasedURLHandlerWithSink) GetStoredPayloadForURL(url string, container interface{}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported method FileBasedURLHandlerWithSink.GetStoredPayloadForURL should have comment or be unexported

@@ -11,6 +11,10 @@ func (iat ImageAndTag) Tag() string {
return iat.tag
}

func (iat ImageAndTag) HasTag() bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported method ImageAndTag.HasTag should have comment or be unexported

@j-poecher j-poecher force-pushed the feat/240/send-events-to-PGIs branch from b9b0692 to 04276e2 Compare June 7, 2022 11:16
@j-poecher j-poecher marked this pull request as ready for review June 13, 2022 11:03
Signed-off-by: Joerg Poecher <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

The following Docker Images have been built:
keptncontrib/dynatrace-service:0.23.0-dev-PR-822,keptncontrib/dynatrace-service:0.23.0-dev-PR-822.202206131237

Copy link
Collaborator

@arthurpitman arthurpitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthurpitman arthurpitman merged commit 6fcb16b into master Jun 13, 2022
@arthurpitman arthurpitman deleted the feat/240/send-events-to-PGIs branch June 13, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynatrace Events should be sent to PGIs by default and not SERVICES
2 participants