feat: Add context to Keptn clients #792

arthurpitman · 2022-04-29T11:05:19Z

Addresses #729

github-actions · 2022-04-29T11:07:04Z

internal/action/action_finished_event_handler.go

+	log "github.com/sirupsen/logrus"
+)
+
+type ActionFinishedEventHandler struct {


[golint] _{reported by reviewdog 🐶}
exported type ActionFinishedEventHandler should have comment or be unexported

github-actions · 2022-04-29T11:07:05Z

internal/action/action_finished_event_handler.go

+	log "github.com/sirupsen/logrus"
+)
+
+type ActionFinishedEventHandler struct {


[golint] _{reported by reviewdog 🐶}
type name will be used as action.ActionFinishedEventHandler by other packages, and that stutters; consider calling this FinishedEventHandler

github-actions · 2022-04-29T11:07:05Z

internal/action/test_finished_event_handler.go

+	"github.com/keptn-contrib/dynatrace-service/internal/keptn"
+)
+
+type TestFinishedEventHandler struct {


[golint] _{reported by reviewdog 🐶}
exported type TestFinishedEventHandler should have comment or be unexported

github-actions · 2022-04-29T11:07:05Z

internal/health/health_endpoint.go

+}
+
+// HealthEndpoint is a HTTP server that offers a health endpoint.
+type HealthEndpoint struct {


[golint] _{reported by reviewdog 🐶}
type name will be used as health.HealthEndpoint by other packages, and that stutters; consider calling this Endpoint

github-actions · 2022-04-29T11:07:05Z

internal/keptn/keptn_client.go

@@ -96,35 +97,35 @@ func NewDefaultClient(event event.Event) (*Client, error) {
 	return NewClient(kClient), nil
 }

-func (c *Client) GetCustomQueries(project string, stage string, service string) (*CustomQueries, error) {
+func (c *Client) GetCustomQueries(ctx context.Context, project string, stage string, service string) (*CustomQueries, error) {


[golint] _{reported by reviewdog 🐶}
exported method Client.GetCustomQueries should have comment or be unexported

github-actions · 2022-04-29T11:07:05Z

internal/keptn/keptn_client.go

 	if err != nil {
 		return nil, err
 	}

 	return &CustomQueries{values: customQueries}, nil
 }

-func (c *Client) GetShipyard() (*keptnv2.Shipyard, error) {
-	shipyard, err := c.client.GetShipyard()
+func (c *Client) GetShipyard(ctx context.Context) (*keptnv2.Shipyard, error) {


[golint] _{reported by reviewdog 🐶}
exported method Client.GetShipyard should have comment or be unexported

github-actions · 2022-04-29T11:07:05Z

internal/keptn/keptn_client.go

 	if err != nil {
 		return nil, fmt.Errorf("failed to retrieve shipyard for project %s: %v", c.client.Event.GetProject(), err)
 	}

 	return shipyard, nil
 }

-func (c *Client) SendCloudEvent(factory adapter.CloudEventFactoryInterface) error {
+func (c *Client) SendCloudEvent(ctx context.Context, factory adapter.CloudEventFactoryInterface) error {


[golint] _{reported by reviewdog 🐶}
exported method Client.SendCloudEvent should have comment or be unexported

github-actions · 2022-04-29T11:07:05Z

internal/onboard/service_sync.go

-func (s *ServiceSynchronizer) Run() {
+// Run runs the service synchronizer which does not return unless cancelled.
+// Cancelling runCtx will stop any new synchronization runs, cancelling synchronizationCtx will stop an in progress synchronization.
+func (s *ServiceSynchronizer) Run(runCtx context.Context, synchronizationCtx context.Context) {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:07Z

cmd/main.go

 	return 0
 }

-func gotEvent(ctx context.Context, event cloudevents.Event) error {
-	err := event_handler.NewEventHandler(event).HandleEvent()
+func gotEvent(workCtx context.Context, replyCtx context.Context, event cloudevents.Event) {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:07Z

internal/action/action_finished_event_handler.go

+}
+
+// HandleEvent handles an action finished event.
+func (eh *ActionFinishedEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:08Z

internal/action/action_started_event_handler.go

-func (eh *ActionStartedEventHandler) HandleEvent() error {
-	pid, err := eh.eClient.FindProblemID(eh.event)
+// HandleEvent handles an action started event.
+func (eh *ActionStartedEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:08Z

internal/action/action_triggered_event_handler.go

-func (eh *ActionTriggeredEventHandler) HandleEvent() error {
-	pid, err := eh.eClient.FindProblemID(eh.event)
+// HandleEvent handles an action triggered event.
+func (eh *ActionTriggeredEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:08Z

internal/action/deployment_finished_event_handler.go

+}
+
+// HandleEvent handles a deployment finished event.
+func (eh *DeploymentFinishedEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:09Z

internal/event_handler/error_handler.go

@@ -28,7 +30,8 @@ func NewErrorHandler(err error, event cloudevents.Event, uniformClient keptn.Uni
 	}
 }

-func (eh ErrorHandler) HandleEvent() error {
+// HandleEvent handles errors by sending an error event.
+func (eh ErrorHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:09Z

internal/event_handler/no_op_handler.go

 type NoOpHandler struct {
 }

-func (eh NoOpHandler) HandleEvent() error {
+// HandleEvent handles an event by doing nothing.
+func (eh NoOpHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:10Z

internal/monitoring/configure_monitoring_event_handler.go

-func (eh ConfigureMonitoringEventHandler) HandleEvent() error {
-	err := eh.configureMonitoring()
+// HandleEvent handles a configure monitoring event.
+func (eh ConfigureMonitoringEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:10Z

internal/problem/problem_event_handler.go

@@ -37,24 +39,25 @@ type RemediationTriggeredEventData struct {
 	Problem RawProblem `json:"problem"`
 }

-func (eh ProblemEventHandler) HandleEvent() error {
+// HandleEvent handles a problem event.
+func (eh ProblemEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:10:10Z

internal/sli/get_sli_triggered_event_handler.go

@@ -42,13 +43,14 @@ func NewGetSLITriggeredHandler(event GetSLITriggeredAdapterInterface, dtClient d
 	}
 }

-func (eh GetSLIEventHandler) HandleEvent() error {
+// HandleEvent handles a get-SLI triggered event.
+func (eh GetSLIEventHandler) HandleEvent(workCtx context.Context, replyCtx context.Context) error {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:48:30Z

cmd/then_context.go

+	"time"
+)
+
+func ThenWithTimeout(parent context.Context, waitCtx context.Context, timeout time.Duration) (context.Context, func()) {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-05-03T12:48:31Z

cmd/then_context.go

+	"time"
+)
+
+func ThenWithTimeout(parent context.Context, waitCtx context.Context, timeout time.Duration) (context.Context, func()) {


[golint] _{reported by reviewdog 🐶}
exported function ThenWithTimeout should have comment or be unexported

github-actions · 2022-05-03T14:02:03Z

cmd/then_context.go

+)
+
+// newThenWithTimeoutContext creates a new Context that is done after timeout after waitCtx is done or if parentCtx is done. It returns the new context and a function that cancels the context.
+func newThenWithTimeoutContext(parentCtx context.Context, waitCtx context.Context, timeout time.Duration, name string) (context.Context, func()) {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

sonarqubecloud · 2022-05-04T06:51:10Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
14 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2022-06-10T15:49:34Z

cmd/main.go

+	}
+}
+
+func gotEvent(workCtx context.Context, replyCtx context.Context, keptnClient *keptn.Client, event cloudevents.Event) {


[golint] _{reported by reviewdog 🐶}
context.Context should be the first parameter of a function

github-actions · 2022-06-28T08:49:34Z

internal/monitoring/configure_monitoring_event_handler.go

@@ -59,7 +59,7 @@ func (eh *ConfigureMonitoringEventHandler) configureMonitoring(ctx context.Conte
 	keptnCredentialsCheckResult := eh.checkKeptnCredentials(ctx)
 	log.WithField("result", keptnCredentialsCheckResult).Info("Checked Keptn credentials")

-	shipyard, err := eh.shipyardReader.GetShipyard(eh.event.GetProject())
+	shipyard, err := eh.shipyardReader.GetShipyard(ctx, eh.event.GetProject())


[golangci-lint] _{reported by reviewdog 🐶}
eh.event.GetProject undefined (type ConfigureMonitoringAdapterInterface has no field or method GetProject) (typecheck)

Signed-off-by: Arthur Pitman <[email protected]>

sonarqubecloud · 2022-06-29T08:11:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

github-actions · 2022-06-29T08:14:49Z

The following Docker Images have been built:
keptncontrib/dynatrace-service:0.23.0-dev-PR-792,keptncontrib/dynatrace-service:0.23.0-dev-PR-792.202206290811

j-poecher

lgtm

github-actions bot reviewed Apr 29, 2022

View reviewed changes

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch from df8981b to 5d067ac Compare May 3, 2022 12:08

github-actions bot reviewed May 3, 2022

View reviewed changes

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch from cbcd8c7 to 714440d Compare May 4, 2022 06:50

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch from 714440d to ce669df Compare June 10, 2022 15:47

github-actions bot reviewed Jun 10, 2022

View reviewed changes

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch from ce669df to ca2517d Compare June 14, 2022 12:01

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch from eae87fa to 241ec09 Compare June 28, 2022 08:49

github-actions bot reviewed Jun 28, 2022

View reviewed changes

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch 2 times, most recently from 281e2f3 to 07d3499 Compare June 29, 2022 08:08

feat: Add context to Keptn clients

a2c8600

Signed-off-by: Arthur Pitman <[email protected]>

arthurpitman force-pushed the feature/729/add-context-to-keptn-clients branch from 07d3499 to a2c8600 Compare June 29, 2022 08:10

arthurpitman marked this pull request as ready for review June 29, 2022 08:14

arthurpitman requested review from agrimmer, heckelmann, hubmat00, jskelin, j-poecher and Kavindu-Dodan as code owners June 29, 2022 08:14

j-poecher approved these changes Jun 29, 2022

View reviewed changes

arthurpitman merged commit 2408c78 into master Jun 29, 2022

arthurpitman deleted the feature/729/add-context-to-keptn-clients branch June 29, 2022 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add context to Keptn clients #792

feat: Add context to Keptn clients #792

arthurpitman commented Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot Apr 29, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

github-actions bot May 3, 2022

sonarqubecloud bot commented May 4, 2022

github-actions bot Jun 10, 2022

github-actions bot Jun 28, 2022

sonarqubecloud bot commented Jun 29, 2022

github-actions bot commented Jun 29, 2022

j-poecher left a comment

feat: Add context to Keptn clients #792

feat: Add context to Keptn clients #792

Conversation

arthurpitman commented Apr 29, 2022

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot Apr 29, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

github-actions bot May 3, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented May 4, 2022

github-actions bot Jun 10, 2022

Choose a reason for hiding this comment

github-actions bot Jun 28, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 29, 2022

github-actions bot commented Jun 29, 2022

j-poecher left a comment

Choose a reason for hiding this comment