Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions w/ Key/Legend changes #8

Open
kentfredric opened this issue May 19, 2016 · 0 comments
Open

Suggestions w/ Key/Legend changes #8

kentfredric opened this issue May 19, 2016 · 0 comments

Comments

@kentfredric
Copy link
Member

<haarg> kentnl: in Devel-Isa-Explainer, i'd suggest using "Legend" rather than "Key".  possibly with an option to hide it.
*** Mode #moose +o osfameron by GumbyNET5
<haarg> http://paste.scsys.co.uk/516146 also maybe something like this.  or maybe aligning things differently.
<haarg> it isn't very clear to read currently
<kentnl> haarg: yeah. EFUTURE.  Actual implementation details of that aren't settled yet so I don't want to prematurely expose config options.
<kentnl> there's a few other things I have to sort out there specifically  as well :/
diff --git i/lib/Devel/Isa/Explainer.pm w/lib/Devel/Isa/Explainer.pm
index cb213fa..313b663 100644
--- i/lib/Devel/Isa/Explainer.pm
+++ w/lib/Devel/Isa/Explainer.pm
@@ -101,21 +101,18 @@ sub _pp_sub {

 sub _pp_key {
   my @tokens;
-  push @tokens, 'Public Sub: ' . _hl_PUBLIC('foo_example');
-  push @tokens, 'Type Constraint: ' . _hl_TYPE('TypeName');
-  push @tokens, 'Type Constraint Utility: ' . _hl_TYPE_UTIL('typeop_TypeName');
-  push @tokens, 'Private/Boring Sub: ' . _hl_PRIVATE('foo_example');
+  push @tokens, _hl_PUBLIC('public_sub');
+  push @tokens, _hl_TYPE('TypeConstraint');
+  push @tokens, _hl_TYPE_UTIL('utility_ForTypeConstraint');
+  push @tokens, _hl_PRIVATE('private_or_boring_sub');
   if ($SHOW_SHADOWED) {
-    push @tokens, 'Public Sub shadowing another: ' . _hl_PUBLIC( 'shadowing_example', 0, 1 );
-    push @tokens, 'Public Sub shadowed by higher scope: ' . _hl_PUBLIC( 'shadowed_example', 1 );
-    push @tokens, 'Public Sub shadowing another and shadowed itself: ' . _hl_PUBLIC( 'shadowed_shadowing_example', 1, 1 );
-
-    push @tokens, 'Private/Boring Sub shadowing another: ' . _hl_PRIVATE( 'shadowing_example', 0, 1 );
-    push @tokens, 'Private/Boring Sub shadowed by higher scope: ' . _hl_PRIVATE( 'shadowed_example', 1 );
-    push @tokens, 'Private/Boring Sub another and shadowed itself: ' . _hl_PRIVATE( 'shadowing_shadowed_example', 1, 1 );
+    push @tokens, _hl_PUBLIC( 'shadowing_sub', 0, 1 );
+    push @tokens, _hl_PUBLIC( 'shadowed_sub', 1 );
+    push @tokens, _hl_PRIVATE( 'private_shadowing_sub', 0, 1 );
+    push @tokens, _hl_PRIVATE( 'private_shadowed', 1 );
   }
   push @tokens, 'No Subs: ()';
-  return sprintf "Key:\n$INDENT%s\n\n", join qq[\n$INDENT], @tokens;
+  return sprintf "Legend:\n$INDENT%s\n\n", join qq[\n$INDENT], @tokens;
 }

 sub _mg_sorted {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant