fix(definitions): export correct types for wait and waitForExpect #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 85 85
Branches 19 19
=====================================
Hits 85 85Continue to review full report at Codecov.
|
|
just writing to say thank you. i use typescript and this fix is exactly what i need to use it. |
|
Thanks for the review @tsiq-swyx. I'll go ahead and merge this. |
|
mind pushing a patch version to npm for this when you get time? my CI thing doesnt like v1.9.3 because of this thing. no rush at all. |
|
Hmmm... It should have published a new release automatically. I'm not sure what went wrong. I'll look into it. |
kentcdodds
pushed a commit
that referenced
this pull request
Apr 2, 2018
There was an issue with a patch release, so this manual-releases.md change is to release a new patch version. Reference: #33
|
Ok, 1.9.4 has been published! |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
Add @weyert as a contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Updates to
waitandwaitForExpectTypescript definitionsWhy: The types are incorrect -
waitshould not be a default export andwaitForExpectwas missing argumentsHow:
Checklist: