fix(textMatch): if the textToMatch is not a string then it wont match

testing-library · Mar 29, 2018 · 9792568 · 9792568
1 parent e9b603d
commit 9792568
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/__tests__/element-queries.js b/src/__tests__/element-queries.js
@@ -76,7 +76,10 @@ test('totally empty label', () => {
 
 test('get element by its alt text', () => {
   const {getByAltText} = render(
-    <img alt="finding nemo poster" src="/finding-nemo.png" />,
+    <div>
+      <input data-info="no alt here" />
+      <img alt="finding nemo poster" src="/finding-nemo.png" />
+    </div>,
   )
   expect(getByAltText(/fin.*nem.*poster$/i).src).toBe('/finding-nemo.png')
 })

diff --git a/src/utils.js b/src/utils.js
@@ -1,5 +1,8 @@
 //eslint-disable-next-line import/prefer-default-export
 export function matches(textToMatch, node, matcher) {
+  if (typeof textToMatch !== 'string') {
+    return false
+  }
   if (typeof matcher === 'string') {
     return textToMatch.toLowerCase().includes(matcher.toLowerCase())
   } else if (typeof matcher === 'function') {