chore(ts): Move typings to DefinitelyTyped, Close #68 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Aug 17, 2019
kentcdodds
reviewed
Aug 17, 2019
| @@ -77,24 +78,13 @@ npm install --save-dev @testing-library/cypress | |||
|
|
|||
| ### With TypeScript | |||
|
|
|||
| Typings are defined under `@testing-library/cypress/typings`, and should be | |||
There was a problem hiding this comment.
I love that people won't have to bother with this anymore.
|
I think the build failure was a fluke. I hope so anyway. |
|
@all-contributors please add @simjes for code |
|
I've put up a pull request to add @simjes! 🎉 |
|
Sweet, I hope so too 😄 Will send a PR to update testing-library/testing-library-docs as well |
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Moved typings to DefinitelyTyped.
See https://www.npmjs.com/package/@types/testing-library__cypress and DefinitelyTyped/DefinitelyTyped#37692
Why:
To close issue #68
Checklist: